Documenting C++ Code¶

Note

This is a preview documentation format specification. Software documentation should currently be written in the format described at https://confluence.lsstcorp.org/display/LDMDG/Documentation+Standards

We document C++ code in two ways:

By writing documentation blocks for all public or protected C++ components (namespaces, types, methods, functions, and constants).

The LSST Stack uses Doxygen to build C++ API reference documentation from comment blocks. This documentation is exposed to users in a variety of contexts, from developers reading the code to readers of the Stack Documentation.

Doxygen comment blocks are the public specification of our C++ API.
By commenting our code internally with C++ comments (// or /* .. */).

These comments are meant to be read only by developers reading and editing the source code.

This page focuses on public code documentation using Doxygen, while internal comments are discussed in our DM C++ Style Guide.

Treat the guidelines on this page as an extension of the DM C++ Style Guide.

Note

Changes to this document must be approved by the System Architect (RFC-24). To request changes to these standards, please file an RFC.

This document is ported from original documentation in Confluence; https://confluence.lsstcorp.org/display/LDMDG/Documentation+Standards. This guide will evolve as a mechanism to document C++ APIs wrapped in Python is developed.

Boilerplate for Header (.h) and Source (.cc) Files¶

The beginning of both header and source code files should include

A formating hint for Emacs
```
// -*- lsst-c++ -*-
```

A copyright and license block (note: NOT a Doxygen comment block)

/*
 * LSST Data Management System
 * Copyright 2008-2017 AURA/LSST.
 *
 * This product includes software developed by the
 * LSST Project (http://www.lsst.org/).
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the LSST License Statement and
 * the GNU General Public License along with this program. If not,
 * see <http://www.lsstcorp.org/LegalNotices/>.
 */

Basic Format of Documentation Blocks¶

This page covers the most important concepts in writing Doxygen-friendly C++ comments for the LSST Stack, though Doxygen’s manual is the most comprehensive reference.

Documentation MUST be delimited in Javadoc style¶

Multi-line documentation blocks must begin with /** and end in */. Single-line documentation blocks must begin with ///. For consistency, do not begin documentation blocks with /*! or //!.

(Note: one-line documentation blocks are rarely used for public APIs, see Common Structure of Documentation Blocks.)

Under certain circumstances, single-line documentation blocks may begin with ///< instead of ///. These cases are indicated below.

Multi-line documentation delimiters SHOULD be on their own lines¶

A multi-line documentation block’s summary sentence should occur on the line after the opening /**, and the terminating */ should be on its own line. An example:

/**
 * Sum numbers in a vector.
 *
 * This sum is the arithmetic sum, not some other kind of sum that only
 * mathematicians have heard of.
 *
 * @param values Container whose values are summed.
 * @return sum of `values`, or 0.0 if `values` is empty.
 */

Documentation MUST use Javadoc-style tags¶

Documentation blocks must use tags such as @see or @param in place of \see or \param. This is both for internal consistency and to avoid conflicts with other tools that give special treatment to \word.

Documentation SHOULD use Markdown for formatting¶

LSST uses Markdown-formatted Doxygen comment blocks. If a particular format cannot be expressed using Markdown, you MAY use Doxygen’s built-in formatting or, if necessary, HTML markup.

Documentation MUST appear where a component is first declared¶

In general, this means documentation blocks will appear in header (.h) files rather than source (.cc) files. This keeps all the documentation with the API and avoids certain false alarms when Doxygen parses C++11 code.

Documentation MUST appear before the declaration it describes, and with the same indentation¶

For example:

/**
 * Sum numbers in a vector.
 *
 * @param values Container whose values are summed.
 * @return sum of `values`, or 0.0 if `values` is empty.
 */
double sum(std::vector<double> & const values) {
    ...
}

Not:

double sum(std::vector<double> & const values) {
    /**
     * Sum numbers in a vector.
     *
     * @param values Container whose values are summed.
     * @return sum of `values`, or 0.0 if `values` is empty.
     */
    ...
}

Common Structure of Documentation Blocks¶

We organize Doxygen comment blocks into sections that appear in a common order. This format is analogous to the one adopted for the Python documentation. The sections and their relative order are:

Short Summary
Deprecation Warning (if applicable)
Extended Summary (recommended)
Template Parameters (if applicable; for classes, methods, and functions)
Function/Method Parameters (if applicable; for methods and functions)
Returns (if applicable; for methods and functions)
Throws (if applicable; for methods and functions)
Exception Safety (optional; for methods and functions)
Helper Functions (if applicable; for functions)
Initializer Declaration (optional; for constants)
See Also (optional)
Notes (optional)
References (optional)
Examples (optional)

For summaries of how these sections are composed in specific contexts, see:

Documenting/Defining Packages
Documenting Classes and Type Aliases
Documenting Enumerated Types
Documenting Methods and Functions
Documenting Constants, Variables, and Data Members

Short Summary¶

A one-line summary that does not use variable names or the function’s name. This summary will appear in lists of class/namespace members.

/// Sum two numbers.
double add(double a, double b);

For functions and methods, the summary should be written in the imperative voice (i.e., as a command that the API consumer is giving). Getters and other methods that are more naturally described as values rather than actions may ignore this rule.

Deprecation Warning¶

A @deprecated tag (where applicable) to warn users that the component is deprecated. The text that follows the tag should include:

In what stack version the object was deprecated, and when it will be removed.
Reason for deprecation if this is useful information (object is superseded, duplicates functionality found elsewhere, etc.).
New recommended way of obtaining the same functionality.

/**
 * @deprecated Deprecated in 11_0. `ndobj_old` will be removed in 12_0; it
 *     is replaced by `ndobj_new` because the latter works also with array
 *     subclasses.
 */

Extended Summary¶

A few sentences giving an extended description. This section should be used to clarify functionality, not to discuss implementation detail or background theory, which should rather be explored in the Notes section below. You may refer to the parameters and the function name, but parameter descriptions still belong in the Function/Method Parameters section unless they are very lengthy.

This section may include mathematical equations to describe the behavior of a class or method, but be sure to put math that pertains only to the implementation in the Notes section rather than the extended description. Equations may be written in LaTeX format:

/**
 * The FFT is a fast implementation of the discrete Fourier transform:
 * @f[ X(e^{j\omega } ) = x(n)e^{ - j\omega n} @f]
 */

LaTeX environments can also be used:

/**
 * The discrete-time Fourier time-convolution property states that
 * @f{eqnarray*}
 * x(n) * y(n) \Leftrightarrow X(e^{j\omega } )Y(e^{j\omega } )\\
 * another equation here
 * @f}
 */

Math can also be used inline:

/**
 * Fit a model of the form @f$y = a x + b@f$ to the data.
 */

Note that LaTeX is not particularly easy to read, so use equations judiciously. In particular, do not use inline LaTeX just to add Greek or other special symbols; prefer HTML character entities or Unicode instead.

Doxygen recovers poorly from typos in formulas; you may need to manually delete docs/html/formula.repository if it contains a bad formula.

Images are allowed, but should not be central to the explanation; users viewing the documentation as text must be able to comprehend its meaning without resorting to an image viewer. These additional illustrations are included using:

/**
 * @image html filename ["caption"]
 */

where filename is a path relative to the project root directory.

Template Parameters¶

A series of @tparam tags, usually one for each template parameter. Each tag should have a description following the parameter name. You do not usually need to document default values; Doxygen will provide the default automatically. If the description extends over multiple lines, each line after the first must be indented.

Parameters should be listed in the same order as they appear in the class, function, or method signature.

/**
 * Storage for arbitrary data with log(N) lookup.
 *
 * ...
 *
 * @tparam T the type of data stored in the table
 * @tparam ComparatorT callable defining a strict weak ordering for objects
 *     of type `T`. Its `operator()` must accept two `T` and return `true`
 *     if and only if the first argument comes before the second. It must
 *     not throw exceptions.
 */
template <typename T, typename ComparatorT = std::less<T>>
class LookupTable
{
    ...
}

When two or more consecutive template parameters have exactly the same description, they can be combined:

/**
 * @tparam T,U the types of the pair components
 */

Do not use a space between the parameters, or Doxygen will not parse the command correctly.

Template Specializations¶

When a partial template specialization reuses parameters from the full template, there is no need to redocument each parameter. If you are omitting the parameters, the documentation must include a cross-reference to the full template, possibly as part of the See Also section.

You must redocument the parameters if the template specialization redefines any parameters (e.g., if the generic parameter T becomes T* in the specialization) or if it places additional restrictions on their values.

Function/Method Parameters¶

A series of @param tags, usually one for each parameter. Each tag should have a description following the parameter name. You do not usually need to document default arguments; Doxygen will provide the default automatically. If the description extends over multiple lines, each line after the first must be indented.

Parameters should be listed in the same order as they appear in the function or method signature.

@param should be given with the [in], [out], or [in,out] tag if the function method contains any output parameters. The [in] tag is optional if all parameters are input, even if other functions or methods in the same class or package use output parameters.

/**
 * Compute mean and standard deviation for a collection of data.
 *
 * @param[out] mean the mean of `data`, or `NaN` if `data` is empty
 * @param[out] stdDev the unbiased (sample) standard deviation, or `NaN`
 *     if `data` contains fewer than 2 elements
 * @param[in] data the data to analyze
 */
void computeStatistics(double & mean, double & stdDev, std::vector<double> const & data);

When two or more consecutive parameters have exactly the same description, they can be combined:

/**
 * @param x,y the coordinates where the function is evaluated
 */

Do not use a space between the parameters, or Doxygen will not parse the command correctly.

Annotating Parameters with Inline Comments (historical)¶

An alternative to the @param tag is to use an inline comment after each parameter, one per line. These comments are prefixed with ///<.

This style is permitted for historical reasons, but should not be used in new code. If the parameter descriptions are too long to fit in a single line of source, the @param documentation method must be used.

Returns¶

A @returns tag, followed by a description similar to the one for Function/Method Parameters. If the returned value is a map, ensure that the key-value pairs are documented in the description.

For consistency with Python documentation, always use @returns and not the synonymous @return.

Throws¶

A series of @throws tags, one for each type of exception (see the style guide). Each tag should have a description following the exception type. If the description extends over multiple lines, each line after the first must be indented.

/**
 * Write an image to disk.
 *
 * @throws IoError Thrown if `fileName` could not be written to.
 */
void writeImage(std::string const & fileName);

Doxygen will render one or more @throws tags as a table of exceptions and descriptions, so do not treat @throws as the first word of the description.

For consistency with Python documentation, always use @throws and not the synonymous @throw or @exception.

Exception Safety¶

Whether or not there are any @throws tags for specific exceptions, a function or method should have an @exceptsafe tag. The description following the tag should describe the level of exception safety provided by the function or method.

The following terms may be used for brevity:

no-throw: The function is guaranteed to always return without throwing an exception.
strong: If the function throws an exception, the program will be in the same state as before the call; i.e., failed calls have no side effects.
basic: If the function throws an exception, the program will be in a valid state, but not necessarily a predictable one. No memory, file descriptors, locks, or other resources will be leaked.
none: If the function throws an exception, objects may be corrupted and unsafe to use, or resources may be leaked.

Examples:

/**
 * Image associated with this map.
 *
 * @exceptsafe Shall not throw exceptions.
 */
ImageF getImage() const noexcept;

/**
 * Apply a user-specified transformation to an image.
 *
 * @exceptsafe If `transform` provides basic exception safety, then this
 *     method shall provide strong exception safety. Otherwise, it provides
 *     no exception safety guarantee.
 */
template <class Func>
ImageF transformImage(Func const & transform) const;

Helper Functions¶

Some operations on a class, particularly arithmetic operators, must be implemented as standalone functions even though they are conceptually part of the class. These functions should have the @relatesalso tag, followed by the name of the appropriate class. They will appear on the class’s documentation page under the heading “Related Functions”. Use this tag sparingly.

For internal consistency, always use @relatesalso and not the synonymous @relatedalso.

Examples:

/**
 * Add two images pixel-by-pixel.
 *
 * @relatesalso ImageF
 */
ImageF operator+(ImageF const & lhs, ImageF const & rhs);

Initializer Declaration¶

By default, Doxygen shows the values of constants unless they are very long. The @showinitializer and @hideinitializer tags override this behavior.

/**
 * Maximum number of simultaneous readers supported.
 *
 * @hideinitializer
 */
int const MAX_READERS = 16;    // Value is implementation detail and subject to change

Notes¶

Notes is an optional section that provides additional information about the code, possibly including a discussion of the algorithm or known limitations of the code. The notes must be prefixed by a @note or @warning command. Equations or images may be used as described in Extended Summary.

For internal consistency, always use @note and not the synonymous @remark or @remarks.

References¶

References can be included either in the ‘Notes’ section or in a separate list below them. A reference consists of the @cite tag, followed by a BibTeX label. Bibfiles must be listed in the CITE_BIB_FILES configuration tag in doc/doxygen.conf.in.

Note that Web pages should be referenced with regular inline links.

References are meant to augment the documentation, but should not be required to understand it.

Examples¶

‘Examples’ is an optional section for examples. This section is very strongly encouraged.

Examples should be prefixed by @code and suffixed by @endcode:

/**
 * @code
 * auto cosines = cos(angles);
 * @endcode
 *
 * Comment explaining the second example.
 *
 * @code
 * auto cosines = cos(radians(angles));
 * @endcode
 */

Documenting/Defining Packages¶

Each LSST package corresponds to a group in Doxygen. We declare this package in the root header file for a package, usually named package.h.

In this header file, below the boilerplate but above any #include statements or other code, provide a Doxygen comment block that declares the package with the fields:

@defgroup followed by machine-readable and human-readable names for the package
Short Summary (must be prefixed by @brief because the summary is not the first line.)
Deprecation Warning (if applicable)
Extended Summary (recommended)
See Also (optional)

For example:

/**
 * @defgroup afw LSST Framework
 *
 * @brief LSST data management: astronomical framework, including images and tables
 */

Header files that belong to the package should have a Doxygen comment like

/**
 * @addtogroup group
 *
 * @{
 */

before any documented code, and a Doxygen comment with a @} after any documented code. Everything between the @{ and the @} will be listed on the module page.

Documenting Classes and Type Aliases¶

Class documentation blocks are placed immediately before the class declaration, and serve to document the class as a whole rather than individual methods.

Short Summary
Deprecation Warning (if applicable)
Extended Summary (recommended)
Template Parameters (if applicable)
See Also (optional)
Notes (optional)
References (optional)
Examples (optional)

For example:

/**
 * Implementation of a trace facility for LSST
 *
 * Tracing is controlled on a per "component" basis, where a "component" is a
 * name of the form aaa.bbb.ccc where aaa is the Most significant part; for
 * example, the utilities library might be called "utils", the doubly-linked
 * list "utils.dlist", and the code to destroy a list "utils.dlist.del"
 *
 */
class TraceImpl
{
    public:
        ...
}

Type alias declarations and typedefs should also be documented, although just a short summary is usually sufficient. Doxygen will automatically provide links to the types being renamed, if their documentation is available.

Documenting Enumerated Types¶

An enumerated type is a type, and should be documented similarly to a class:

Short Summary
Deprecation Warning (if applicable)
Extended Summary (recommended)
See Also (optional)
Notes (optional)
References (optional)

In addition, each value of the type should be documented. A short description is almost always sufficient.

For example:

/**
 * Supported coordinate systems for flux-conserving transformations.
 *
 * These values are used in arguments to various functions in this package.
 * Unless otherwise stated, these functions do not validate whether the data
 * set makes sense in the "from" coordinates.
 */
enum class CoordType
{
    /// Untransformed detector coordinates.
    PIXEL,
    /// Idealized detector coordinates after applying a distortion correction.
    WARP_PIXEL,
    /// Equatorial J2000.0 coordinates.
    SKY_WCS
};

Annotating Enum Values with Inline Comments (optional)¶

If the value descriptions are very short, you may choose to annotate values with inline comments after each constant, one per line. These comments are prefixed with ///<.

For example:

enum class CoordType
{
    PIXEL,    ///< Untransformed detector coordinates
    WARP_PIXEL,    ///< Distortion-corrected detector coordinates
    SKY_WCS    ///< Equatorial J2000.0 coordinates
};

If the constant descriptions are too long to fit in a single line of source, ordinary documentation blocks before each constant must be used.

Documenting Methods and Functions¶

All public or protected methods and all functions must be preceded by a documentation block. Method or function documentation blocks contain the following sections:

Short Summary
Deprecation Warning (if applicable)
Extended Summary (recommended)
Template Parameters (if applicable)
Function/Method Parameters (if applicable)
Returns (if applicable)
Throws (if applicable)
Exception Safety (optional)
Helper Functions (if applicable; for functions only)
See Also (optional)
Notes (optional)
References (optional)
Examples (optional)

An example:

/**
 * Read an image from disk.
 *
 * @param fileName the file to read. Must be either absolute or relative to
 *     the program working directory.
 *
 * @return the image stored in `fileName`. If the image on disk does not
 *     have `double` pixels, they will be cast to `double`.
 *
 * @throws IoError Thrown if `fileName` does not exist or is not readable.
 *
 * @exceptsafe Strong exception guarantee.
 */
lsst::afw::image::Image<double> loadImage(std::string const & fileName);

Overloaded Function/Method Definitions¶

@overload may be used when two methods/functions are effectively the same but have different parameter lists for reasons of convenience. Use this tag only when the specification of the abbreviated overload can be easily inferred from the fully documented one.

The text generated by the @overload tag tells readers to see the method “above”. Because Doxygen sorts the detailed documentation of namespace and class members, you should check the generated documentation to make sure the fully documented overload appears before any that use the @overload tag.

For example:

/**
 * Sum numbers in a vector.
 *
 * @param values Container whose values are summed.
 * @return sum of `values`, or 0.0 if `values` is empty.
 *
 * @exceptsafe This function does not throw exceptions.
 */
double add(std::vector<double> const & values);

/**
 * Sum numbers in an array.
 *
 * @overload double add(std::vector<double> const &)
 */
double add(double[] const values, size_t nValues);

Documenting Constants, Variables, and Data Members¶

All non-private constants, variables, or data members must be preceded by a documentation block. At minimum, constants/variables/data members should have a summary line, but can also have a more complete structure:

Short Summary
Deprecation Warning (if applicable)
Extended Summary (optional)
Initializer Declaration (optional; for constants only)
Notes (optional)
References (optional)
Examples (optional)

For example:

/// Flag set if background subtraction should not be done.
const int NO_BACKGROUND = 1 << 3;

Annotating Constants and Variables with Inline Comments (optional)¶

If the constant, variable, or data member descriptions are very short, you may choose to annotate them with inline comments after each value, one per line. These comments are prefixed with ///<.

For example:

const int NO_BACKGROUND = 1 << 3;        ///< Skip background subtraction

If the descriptions are too long to fit in a single line of source, ordinary documentation blocks before each value must be used.

Documenting C++ Code¶

Boilerplate for Header (.h) and Source (.cc) Files¶

Basic Format of Documentation Blocks¶

Documentation MUST be delimited in Javadoc style¶

Multi-line documentation delimiters SHOULD be on their own lines¶

Documentation MUST use Javadoc-style tags¶

Documentation SHOULD use Markdown for formatting¶

Documentation MUST appear where a component is first declared¶

Documentation MUST appear before the declaration it describes, and with the same indentation¶

Common Structure of Documentation Blocks¶

Short Summary¶

Deprecation Warning¶

Extended Summary¶

Template Parameters¶

Template Specializations¶

Function/Method Parameters¶

Annotating Parameters with Inline Comments (historical)¶

Returns¶

Throws¶

Exception Safety¶

Helper Functions¶

Initializer Declaration¶

See Also¶

Notes¶

References¶

Examples¶

Documenting/Defining Packages¶

Documenting Classes and Type Aliases¶

Documenting Enumerated Types¶

Annotating Enum Values with Inline Comments (optional)¶

Documenting Methods and Functions¶

Overloaded Function/Method Definitions¶

Documenting Constants, Variables, and Data Members¶

Annotating Constants and Variables with Inline Comments (optional)¶